Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return real image dimensions #50

Merged
merged 1 commit into from
May 19, 2021
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 18, 2021

TODO: we should use the Alchemy thumbnails mixin we still working on

@tvdeyen tvdeyen force-pushed the fix-essence-picture-serializer branch from c5b6ddf to 7b173a3 Compare May 18, 2021 17:18
TODO: we should use the Alchemy thumbnails mixin we still working on
@tvdeyen tvdeyen force-pushed the fix-essence-picture-serializer branch from 7b173a3 to 65794b5 Compare May 18, 2021 17:20
@tvdeyen tvdeyen requested a review from mamhoff May 18, 2021 17:20
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for now! :shipit:

@tvdeyen tvdeyen marked this pull request as ready for review May 19, 2021 07:19
@tvdeyen tvdeyen changed the title WIP: Return real image dimensions Return real image dimensions May 19, 2021
@tvdeyen tvdeyen merged commit 8154ce2 into main May 19, 2021
@tvdeyen tvdeyen deleted the fix-essence-picture-serializer branch May 19, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants