Add legacy URLs to page serializer #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
approved these changes
Feb 20, 2021
|
@pelargir somehow GitHub had hiccups running the build. Mind force pushing again to retrigger? |
pelargir
force-pushed
the
add-legacy-urls-to-page-serializer
branch
from
2f1c709
to
9b4d1b0
Compare
|
@tvdeyen pushed again. |
|
@tvdeyen it still seems to be having problems. Not sure why. |
pelargir
force-pushed
the
add-legacy-urls-to-page-serializer
branch
from
9b4d1b0
to
faba655
Compare
|
@pelargir should be fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds legacy URLs to the page serializer. Since legacy URLs only have one useful field (
urlname) I opted to include these as an attribute on the page instead of creating an extra serializer for legacy URLs.