Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully qualify the names of Serializer classes #18

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Fully qualify the names of Serializer classes #18

merged 1 commit into from
Nov 16, 2020

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Nov 16, 2020

There are naming conflicts with core Alchemy serializers that need to be
resolved cleanly. This does that.

@mamhoff mamhoff requested a review from tvdeyen November 16, 2020 13:48
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better safe than sorry?

app/serializers/alchemy/json_api/element_serializer.rb Outdated Show resolved Hide resolved
There are naming conflicts with core Alchemy serializers that need to be
resolved cleanly. This does that.
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

@mamhoff mamhoff merged commit 53b509f into main Nov 16, 2020
@mamhoff mamhoff deleted the fqcn branch November 16, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants