Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify Record Type and Serializer Class for all relations #17

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Specify Record Type and Serializer Class for all relations #17

merged 1 commit into from
Nov 16, 2020

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Nov 16, 2020

If we don't do this, we run into a bug in production where this gem will
try to load Alchemy's internal serializers (Alchemy::NodeSerializer
and friends).

@mamhoff
Specify Record Type and Serializer Class for all relations
d07a9bf 
If we don't do this, we run into a bug in production where this gem will
try to load Alchemy's internal serializers (`Alchemy::NodeSerializer`
and friends).
@mamhoff mamhoff requested a review from tvdeyen November 16, 2020 12:08
tvdeyen
tvdeyen approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@tvdeyen tvdeyen merged commit a854edb into main Nov 16, 2020
@tvdeyen tvdeyen deleted the specify-serializer-classes branch November 16, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamhoff @tvdeyen