Rename Alchemy::BaseController extension constant #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rails 6 with Zeitwerk we need to make sure that a file contains the constant we the same naming schema. Although the dummy app uses the exact same Rails 6 defaults as a "normal" Rails app this was never catched in specs but in real world apps.
Merged
tvdeyen
added a commit
that referenced
this pull request
Nov 28, 2019
4.3.1 (2019-10-21) - add config/manifest.js to dummy app [#93](#93) ([rmparr](https://github.com/rmparr)) - Use at least Devise 4.7.1 [#90](#90) ([tvdeyen](https://github.com/tvdeyen)) - Rename Alchemy::BaseController extension constant [#87](#87) ([tvdeyen](https://github.com/tvdeyen))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails 6 with Zeitwerk we need to make sure that a file contains
the constant we the same naming schema. Although the dummy app uses
the exact same Rails 6 defaults as a "normal" Rails app this was
never catched in specs but in real world apps.