Add lock

AlbumenJ · Feb 21, 2024 · db1373b · db1373b
1 parent 696b7a9
commit db1373b
Showing 1 changed file with 17 additions and 14 deletions.
diff --git a/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/directory/AbstractDirectory.java b/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/directory/AbstractDirectory.java
@@ -298,17 +298,18 @@ public void discordAddresses() {
 
     @Override
     public void addInvalidateInvoker(Invoker<T> invoker) {
-        // 1. remove this invoker from validInvokers list, this invoker will not be listed in the next time
-        if (removeValidInvoker(invoker)) {
-            // 2. add this invoker to reconnect list
-            invokersToReconnect.add(invoker);
-            // 3. try start check connectivity task
-            checkConnectivity();
-
-            logger.info("The invoker " + invoker.getUrl()
-                    + " has been added to invalidate list due to connectivity problem. "
-                    + "Will trying to reconnect to it in the background.");
-        }
+        LockUtils.safeLock(invokerRefreshLock, 60_000, () -> {
+            // 1. remove this invoker from validInvokers list, this invoker will not be listed in the next time
+            if (removeValidInvoker(invoker)) {
+                // 2. add this invoker to reconnect list
+                invokersToReconnect.add(invoker);
+                // 3. try start check connectivity task
+                checkConnectivity();
+
+                logger.info("The invoker " + invoker.getUrl() + " has been added to invalidate list due to connectivity problem. "
+                        + "Will trying to reconnect to it in the background.");
+            }
+        });
     }
 
     public void checkConnectivity() {
@@ -398,9 +399,11 @@ public void checkConnectivity() {
      * 4. all the invokers disappeared from total invokers should be removed in the disabled invokers list
      */
     public void refreshInvoker() {
-        if (invokersInitialized) {
-            refreshInvokerInternal();
-        }
+        LockUtils.safeLock(invokerRefreshLock, 60_000, () -> {
+                    if (invokersInitialized) {
+                        refreshInvokerInternal();
+                    }
+                });
         MetricsEventBus.publish(
                 RegistryEvent.refreshDirectoryEvent(applicationModel, getSummary(), getDirectoryMeta()));
     }