Test ut workflow v2 #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add three new utility functions: - ValidateProtocol: validate protocol types - CalculateStorageSize: convert size strings to bytes - FormatDuration: format durations as human-readable strings Test the auto-generate unit tests workflow with fixed YAML.
Owner
Author
|
@copilot check current coverage and improve the coverage to above 90 for newly added functions. |
|
@AlbinJohns-wk I've opened a new pull request, #5, to work on those changes. Once the pull request is ready, I'll request review from you. |
9 tasks
…unctions - Added TestCalculateStorageSize with 17 test cases covering: - Valid sizes with binary units (Gi, Mi, Ti, Ki) - Valid sizes with decimal units (G, M, T, k) - Various edge cases (zero, single byte, etc.) - Error cases (empty string, invalid formats, negative values) - Added TestFormatDuration with 26 test cases covering: - Milliseconds formatting - Seconds only formatting - Minutes only formatting - Minutes and seconds formatting - Hours only formatting - Hours and minutes formatting - Large durations - Achieved >90% coverage for both functions: - CalculateStorageSize: 90.9% - FormatDuration: 100.0% - Overall package coverage increased from 74.8% to 96.4% Co-authored-by: AlbinJohns-wk <220135713+AlbinJohns-wk@users.noreply.github.com>
The coverage files were temporary and shouldn't be tracked. Removed the gitignore entry as requested. Co-authored-by: AlbinJohns-wk <220135713+AlbinJohns-wk@users.noreply.github.com>
Add test coverage for CalculateStorageSize and FormatDuration utility functions
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Project tracking
Do any added TODOs have an issue in the backlog?
Did you add unit tests? Why not?
Does this code need functional testing?
Is a code review walkthrough needed? why or why not?
Should additional test coverage be executed in addition to pre-merge?
Does this code need a note in the changelog?
Does this code require documentation changes?
Additional Information