refactor(cli): reduce _output_and_exit cognitive complexity#179
Merged
Alberto-Codes merged 4 commits intomainfrom Feb 27, 2026
Merged
refactor(cli): reduce _output_and_exit cognitive complexity#179Alberto-Codes merged 4 commits intomainfrom
Alberto-Codes merged 4 commits intomainfrom
Conversation
Address two adversarial review findings: use explicit `is not None` instead of truthiness for format resolution (F1), and clarify _emit_findings docstring about empty-findings behavior (F3).
There was a problem hiding this comment.
Pull request overview
Refactors the CLI output pipeline to reduce SonarQube-reported cognitive complexity in _output_and_exit() while aiming to preserve behavior, following the introduction of the JSON output path in #177.
Changes:
- Extract output dispatch into a new private helper
_emit_findings(). - Simplify output format resolution into a single expression.
- Update docstrings to reflect the new structure and responsibilities.
Apply the same `is not None` identity check to `output_path` that was already applied to `fmt_opt`, preserving exact original semantics for both branches of the format resolution ternary.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SonarQube flagged
_output_and_exit()at cognitive complexity 17(threshold 15, target ≤12) after the JSON format branch in #177.
Two changes, no behavior change.
_emit_findings()helper for format dispatch (~5 CC reduction)Test:
uv run pytest tests/unit/test_cli.py::TestOutputAndExit -vCloses #178
PR Review
Checklist
uv run pytest)uv run ruff check .)uv run ty check)!in title andBREAKING CHANGE:in bodyReview Focus
Verify the ternary at line 333 preserves exact semantics of the original if/elif/else. The
is not Noneidentity check (not truthiness) was chosen to match the original contract.Related