Add test coverage for SOURCE keyword - no grammar changes needed#2381
Merged
Add test coverage for SOURCE keyword - no grammar changes needed#2381
Conversation
Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Limit the impact of using the keyword 'Source'
Add test coverage for SOURCE keyword - no grammar changes needed
Dec 16, 2025
mathiasrw
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #2218 requested limiting the impact of SOURCE as a reserved keyword, similar to PR #2203's handling of VALUE/VALUES.
Finding
SOURCE is already in the
NonReservedproduction rule (alasqlparser.jisonlines 3171, 3178), enabling Jison's error recovery to accept it as an identifier while preserving keyword functionality.Changes
test/test2218.js- 7 test cases demonstrating SOURCE works as:SOURCE "file.sql"commands (keyword context)MERGE ... BY SOURCEclauses (keyword context)Example
No grammar modifications required.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.