Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Set cache to using WHERE (NOT) IN #1834

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Add Set cache to using WHERE (NOT) IN #1834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 45 additions & 15 deletions src/50expression.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,13 +483,28 @@
s += '.indexOf(';
s += 'alasql.utils.getValueOf(' + leftJS() + '))>-1)';
} else if (Array.isArray(this.right)) {
// leverage JS Set, which is faster for lookups than arrays
s =
'(new Set([' +
this.right.map(ref).join(',') +
']).has(alasql.utils.getValueOf(' +
leftJS() +
')))';
if (!alasql.options.cache || this.right.filter((value) => value instanceof yy.ParamValue).length > 0) {
// When not using cache, or when the array contains parameters, we need to re-create the Set
// leverage JS Set, which is faster for lookups than arrays
s =
'(new Set([' +
this.right.map(ref).join(',') +
']).has(alasql.utils.getValueOf(' +
leftJS() +
')))';
} else {
// Use a cache to not re-create the Set on every identitical query
if (!alasql.sets) {
alasql.sets = {};
}
const allValues = this.right.map((value) => value.value);
const allValuesStr = allValues.join(",");
if (!alasql.sets[allValuesStr]) {
// leverage JS Set, which is faster for lookups than arrays
alasql.sets[allValuesStr] = new Set(allValues);
}
s = 'alasql.sets["' + allValuesStr + '"].has(alasql.utils.getValueOf(' + leftJS() + '))';
}
} else {
s = '(' + rightJS() + '.indexOf(' + leftJS() + ')>-1)';
//console.log('expression',350,s);
Expand All @@ -505,13 +520,28 @@
s += '.indexOf(';
s += 'alasql.utils.getValueOf(' + leftJS() + '))<0)';
} else if (Array.isArray(this.right)) {
// leverage JS Set, which is faster for lookups than arrays
s =
'(!(new Set([' +
this.right.map(ref).join(',') +
']).has(alasql.utils.getValueOf(' +
leftJS() +
'))))';
if (!alasql.options.cache || this.right.filter((value) => value instanceof yy.ParamValue).length > 0) {
// When not using cache, or when the array contains parameters, we need to re-create the Set
// leverage JS Set, which is faster for lookups than arrays
s =
'(!(new Set([' +
this.right.map(ref).join(',') +
']).has(alasql.utils.getValueOf(' +
leftJS() +
'))))';
} else {
// Use a cache to not re-create the Set on every identitical query
if (!alasql.sets) {
alasql.sets = {};
}
const allValues = this.right.map((value) => value.value);
const allValuesStr = allValues.join(",");
if (!alasql.sets[allValuesStr]) {
// leverage JS Set, which is faster for lookups than arrays
alasql.sets[allValuesStr] = new Set(allValues);
}
s = '!alasql.sets["' + allValuesStr + '"].has(alasql.utils.getValueOf(' + leftJS() + '))';
}
} else {
s = '(' + rightJS() + '.indexOf(';
s += leftJS() + ')==-1)';
Expand Down Expand Up @@ -754,7 +784,7 @@

toString() {
var s;
const {op, right} = this;
const { op, right } = this;
const res = right.toString();

if (op === '~') {
Expand Down
Loading