Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid query throws n.Term is not a constructor #1871

Closed
jcubic opened this issue Feb 1, 2024 · 6 comments · Fixed by #1903
Closed

Invalid query throws n.Term is not a constructor #1871

jcubic opened this issue Feb 1, 2024 · 6 comments · Fixed by #1903

Comments

@jcubic
Copy link

jcubic commented Feb 1, 2024

I've noticed that the error message on the invalid token looks like this:

n.Term is not a constructor

When executing:

> xxxx

It looks like the invalid token is not handled and it just throws an unhandled exception.

You can see this on my Terminal App:

https://codepen.io/jcubic/pen/dVBaRm

@mathiasrw
Copy link
Member

What are you expecting from the query XXXX?

@jcubic
Copy link
Author

jcubic commented Feb 3, 2024

I expected a different error message, like "Invalid Query" or "Invalid Token", but the error is not handled and it throws an internal error.

@vishal6557
Copy link
Contributor

@mathiasrw Can you assign this to me? Thanks!

@jcubic
Copy link
Author

jcubic commented Mar 17, 2024

@vishal6557 Open Source project don't use assignment, especially for people that are outside the project. Where did you learn that project need to assign the task to you?

@vishal6557
Copy link
Contributor

@jcubic Thank you for your feedback! You're right—open-source projects flourish through collaboration and volunteer efforts. My goal was simply to offer help with this issue, aiming to contribute positively without overstepping.

vishal6557 pushed a commit to vishal6557/alasql that referenced this issue Mar 17, 2024
mathiasrw pushed a commit that referenced this issue Mar 18, 2024
Co-authored-by: vishal diyora <vishaldiyora@vishals-MacBook-Pro-2.local>
@mathiasrw
Copy link
Member

Fix released as part of v4.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants