Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: threshold array callback #256

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: threshold array callback #256

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2de434
fix: threshold array callback
iosamuel Nov 6, 2022
776889c
fix: get threshold could be an array
iosamuel Nov 7, 2022
69d5a0b
fix: threshold array conditional
iosamuel Nov 8, 2022
96755c7
fix: threshold conditional result
iosamuel Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/directives/observe-visibility.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class VisibilityState {
}

get threshold () {
return this.options.intersection && typeof this.options.intersection.threshold === 'number' ? this.options.intersection.threshold : 0
return this.options.intersection?.threshold || 0
}

createObserver (options, vnode) {
Expand Down Expand Up @@ -51,9 +51,12 @@ class VisibilityState {
}

if (this.callback) {
// Use isIntersecting if possible because browsers can report isIntersecting as true, but intersectionRatio as 0, when something very slowly enters the viewport.
const result = entry.isIntersecting && entry.intersectionRatio >= this.threshold
if (result === this.oldResult) return
let result = entry.isIntersecting
if (!Array.isArray(this.threshold)) {
// Use isIntersecting if possible because browsers can report isIntersecting as true, but intersectionRatio as 0, when something very slowly enters the viewport.
result &&= entry.intersectionRatio >= this.threshold
if (result === this.oldResult) return
}
this.oldResult = result
this.callback(result, entry)
}
Expand Down