-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
visualize: fix timestamps on diagramms #430
base: main
Are you sure you want to change the base?
Conversation
visualization_results.pdf |
Thank you for your PR! Currently the optimization endpoint (and therefore the visualization) expect the forecast data starting at 00:00 of the current day + x prediction hours (currently 48). The optimization starts at start_hour (default rounded down current hour, e.g. 16:42 -> 16) and goes until optimization hours (currently 48) which starts at 00:00 of the current day just like the predictions (e.g. start_hour = 16, optimization_hours = 48 - > optimization will go until end of the next day). |
@Lasall Yes I understand this in the same way. For the PR it is important, that the timezone in EOS.config.json is set. Otherwise the axis timeline does not match. |
new_optimize_result_2_full.pdf Maybe you could also adjust the relative times "hours since start" to be the same between predictions and optimization?Currently it could be confusing the prediction goes 0-48 and optimization 0-38 (even though optimization_hours is set to 48). |
Did you mean something like this? |
after some code digging I think this is "more" correct. EOS/src/akkudoktoreos/core/ems.py Line 131 in 1a2da76
This line does set the start time to the start of the current hour (if not defined). But imo it should be the start of the next hour, but that's something for an other discussion. |
…ize' into 20240128_fix_visualize
I added the changes. |
Looks good to me, probably need some fine tuning with the optimization diagram (offset +1) but in a different PR (I think that's also what you meant Normann). PDFs from test can be checked out here: https://github.com/Akkudoktor-EOS/EOS/actions/runs/13120831990?pr=430 |
I tried to fix the problem with the timestamps in the diagrams. The discussion you can find in #387.