📝 [FEAT] Add Unit Tests for BeastType Enum and Conversions

[jimenezz22]

📝 Issue Title: Add Unit Tests for BeastType Enum and Conversions

🔍 Scope

The BeastType enum defines different elemental and magical types for beasts, each with custom conversions to felt252 and u8. While the logic is implemented, there are currently no unit tests validating the behavior of these conversions.

This issue involves writing a complete set of unit tests to ensure BeastType conversion logic is correct, handles edge cases, and behaves safely in the game logic.

🔄 How to Implement the Issue

• Step 1: Write tests for the following:

  • BeastType to felt252 using Into<BeastType, felt252>
  • BeastType to u8 using Into<BeastType, u8>
  • u8 to BeastType using Into<u8, BeastType>

• Step 2: Verify correct bidirectional mapping:

  • Each enum variant matches its corresponding numeric and felt252 value.
  • Invalid u8 inputs map to BeastType::Undefined.

• Step 3: Add edge case testing (e.g., max u8 value 255).

✅ Acceptance Criteria

• Unit tests exist for each Into implementation.
• Tests confirm all valid mappings are correct.
• Invalid u8 values result in BeastType::Undefined.
• Tests follow Cairo and Dojo testing conventions.

📸 Additional Context

The BeastType enum plays a key role in game classification, elemental interactions, and behavior logic. Ensuring safe and accurate conversions will prevent state inconsistencies or unexpected logic behavior during battles or UI rendering.

Enum source:
https://github.com/AkatsukiLabs/DojoByExample/blob/main/backend/dojo_examples/combat_game/src/types/beast.cairo

Contribution Guidelines

• Please ensure you read and follow the contribution guidelines in the project's CONTRIBUTIONS GUIDELINES

[morelucks]

Mind if I try this one?

[truthixify]

My Approach to Solving This Issue

As a developer working on game logic and type safety, I’ll focus on ensuring that the BeastType enum’s conversion behavior is predictable, safe, and fully tested. These unit tests will help enforce correctness and guard against regressions in type mappings critical to combat behavior.

---

Phase 1: Branch Setup

I’ll begin by forking the repository and creating a new branch for the tests:

feature/[issue-number]-beasttype-tests

---

Phase 2: Write Core Unit Tests

I will write unit tests covering:

• BeastType to felt252 conversion
• BeastType to u8 conversion
• u8 to BeastType conversion

Each test will validate that every enum variant maps correctly to and from both types.

---

Phase 3: Edge Case and Invalid Input Handling

I will test edge values like u8::MAX (255) to ensure:

• Any out-of-range u8 inputs fall back to BeastType::Undefined
• The implementation behaves safely and as expected under invalid input conditions

---

Phase 4: Validation Against Conventions

I’ll ensure all tests:

• Follow Cairo and Dojo testing patterns
• Use clear naming and structure for maintainability
• Are placed in the appropriate test module for types/beast.cairo

---

Phase 5: Commit & Pull Request

Once the tests pass and meet standards:

• I’ll commit changes with a clear message like: "Test: Add unit tests for BeastType conversions and edge handling"
• I’ll then open a PR with the message: Close #[issue_id]

[mariocodecr]

Hii! My name is Mario Araya, I’m a Software Developer with 2+ years of experience. I have worked with backend technologies such as Cairo, Java, and C#, as well as frontend development using React, NextJS, and JavaScript/TypeScript. I’ve made contributions to open-source projects, completed a Starknet Bootcamp, exercises on NodeGuardians, finished Starklings, and participated in multiple hackathons. I’m also a member of the Dojo Coding community here in Costa Rica.

I will start by creating a dedicated test module (or file) for the BeastType enum within the appropriate testing structure, following Cairo and Dojo conventions. Implement tests for each direction of conversion: from BeastType to felt252 and u8, and vice versa. For each enum variant, assert that the conversion returns the correct corresponding value and that the reverse mapping brings you back to the original variant. Then, test edge cases such as invalid u8 inputs (e.g., 255), confirming that they correctly default to BeastType::Undefined. Ensure the tests are comprehensive, readable, and clearly separated by conversion type, and finally run the full test suite to confirm correctness and stability across all scenarios.

[jimenezz22]

@mariocodecr any updates?

[KevinMomanyi]

Hey! I'm Momanyi Kevin, a junior Web3 developer and security researcher with experience in Cairo, Rust, React Typescript and Javascript.
I'm currently contributing to open-source and am super interested in L2 scaling, DeFi, ZK, etc.
I’d love to work on this issue and already took a look at the codebase and my approach to this is to add Unit Tests for BeastType Enum and Conversions, with a clean testing strategy aligned with Cairo 1.0 and Dojo testing conventions. Let me know if I can be assigned, happy to get started and ask questions along the way!