Skip to content

Add and fix some toString #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 4, 2023
Merged

Add and fix some toString #202

merged 4 commits into from
May 4, 2023

Conversation

ivanyu
Copy link
Contributor

@ivanyu ivanyu commented May 4, 2023

Closes #151

@ivanyu ivanyu requested a review from a team as a code owner May 4, 2023 10:13
jeqo
jeqo approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@jeqo jeqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AnatolyPopov
AnatolyPopov approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@AnatolyPopov AnatolyPopov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @ivanyu do we need to squash?

@jeqo jeqo merged commit 3bb699c into new-implementation May 4, 2023
@jeqo jeqo deleted the ivanyu/tostring branch May 4, 2023 10:19
@ivanyu
Copy link
Contributor Author

ivanyu commented May 4, 2023

@AnatolyPopov I think it's better to keep as is, the commits are meaningful separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnatolyPopov AnatolyPopov AnatolyPopov approved these changes

@jeqo jeqo jeqo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanyu @AnatolyPopov @jeqo