fix: remove parent directories to mimic s3 behaviour #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanyu
requested changes
Apr 20, 2023
...src/main/java/io/aiven/kafka/tieredstorage/commons/storage/filesystem/FileSystemStorage.java
Outdated
Show resolved
Hide resolved
jeqo
commented
Apr 20, 2023
| @@ -64,19 +72,33 @@ public InputStream fetch(final String key, final int from, final int to) throws | |||
| throw new IllegalArgumentException("from cannot be more than to, from=" + from + ", to=" + to + " given"); | |||
| } | |||
|
|
|||
| final Path path = Path.of(fsRoot, key); | |||
| final Path path = fsRoot.resolve(key); | |||
| final long fileSize = Files.size(path); | |||
| if (to > fileSize) { | |||
| throw new IllegalArgumentException("to cannot be bigger than file size, to=" | |||
| + to + ", file size=" + fileSize + " given"); | |||
| } | |||
There was a problem hiding this comment.
Wondering if we should return until the end of the file.
S3 (even though I haven't found it in the docs) doesn't return failure when fetching by range, but returns until the end of the file.
There was a problem hiding this comment.
Good question but I believe we should not rely on this and this should be an error, it's better to fail fast then in the end trying to figure out why a part of the batch is missing.
...src/main/java/io/aiven/kafka/tieredstorage/commons/storage/filesystem/FileSystemStorage.java
Outdated
Show resolved
Hide resolved
AnatolyPopov
requested changes
Apr 20, 2023
...test/java/io/aiven/kafka/tieredstorage/commons/storage/filesystem/FileSystemStorageTest.java
Outdated
Show resolved
Hide resolved
...test/java/io/aiven/kafka/tieredstorage/commons/storage/filesystem/FileSystemStorageTest.java
Outdated
Show resolved
Hide resolved
...test/java/io/aiven/kafka/tieredstorage/commons/storage/filesystem/FileSystemStorageTest.java
Outdated
Show resolved
Hide resolved
...test/java/io/aiven/kafka/tieredstorage/commons/storage/filesystem/FileSystemStorageTest.java
Outdated
Show resolved
Hide resolved
...test/java/io/aiven/kafka/tieredstorage/commons/storage/filesystem/FileSystemStorageTest.java
Outdated
Show resolved
Hide resolved
...test/java/io/aiven/kafka/tieredstorage/commons/storage/filesystem/FileSystemStorageTest.java
Outdated
Show resolved
Hide resolved
...test/java/io/aiven/kafka/tieredstorage/commons/storage/filesystem/FileSystemStorageTest.java
Outdated
Show resolved
Hide resolved
...test/java/io/aiven/kafka/tieredstorage/commons/storage/filesystem/FileSystemStorageTest.java
Outdated
Show resolved
Hide resolved
...test/java/io/aiven/kafka/tieredstorage/commons/storage/filesystem/FileSystemStorageTest.java
Show resolved
Hide resolved
jeqo
force-pushed
the
jeqo/fix-fs-delete
branch
from
120173d to
f4041d2
Compare
AnatolyPopov
reviewed
May 3, 2023
...src/main/java/io/aiven/kafka/tieredstorage/commons/storage/filesystem/FileSystemStorage.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a directory is emptied on S3, the parent keys are removed until an object is found