fix: Allow importing in SSR contexts without error #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow importing OvenPlayer on the server without errors using the following fixes: Update the webpack config to disable chunk loading and set the global Object to work in both contexts. Update VTT.js to work in both contexts. Update resize-sensor to not access window right away.
7 tasks
zusorio
added a commit
to zusorio/OvenPlayer
that referenced
this pull request
Aug 28, 2025
…me polyfills - Remove the WebRTC adapter.js, it wasn't being used - Replace the hardcoded bundle of underscore.js with a version from npm - Remove the dom.js polyfill as it isn't needed in even somewhat modern browsers - Use the VTTCue and VTTRegion polyfills from the media-captions package and remove the hardcoded ones from vtt.js. This could be further optimized by using some of the parsing from media-captions in the future. - Remove the fetch polyfill as it's been available in all browsers since 2017 - Re-organize package.json: Since all dependencies are put in the bundle, they should be in devDependencies to prevent users from unnecessarily installing them - Update webpack config to disable chunkLoading. This is necessary to create a single bundle and was also already done in AirenSoft#481 - I haven't replaced the hardcoded vast-client.js bundle yet, as the version from npm seemed to increase the bundle size by 60kb. I think this didn't happen with the vite version, so this is something we can do in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow importing OvenPlayer on the server without errors using the following fixes:
Closes #482