-
Notifications
You must be signed in to change notification settings - Fork 38
Load musl version of our native addon #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| name: ποΈ Alpine test | ||
|
|
||
| on: | ||
| workflow_call: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| alpine-test: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 5 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| node-version: [16, 18, 20, 22, 24, 25] | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v6 | ||
|
|
||
| - name: Download build artifacts | ||
| uses: actions/download-artifact@v5 | ||
| with: | ||
| name: firewall-node-library-${{ github.sha }} | ||
|
|
||
| - name: Test Zen on Alpine (Node.js ${{ matrix.node-version }}) | ||
| run: bash scripts/test-alpine.sh ${{ matrix.node-version }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /** | ||
| * Detects if the current process is running on a musl-based system (e.g. Alpine Linux). | ||
| * Based on the approach from the detect-libc package. | ||
| */ | ||
| export function isMusl(): boolean { | ||
| if (process.platform !== "linux") { | ||
| return false; | ||
| } | ||
|
|
||
| try { | ||
| const report = process.report?.getReport() as Record<string, unknown>; | ||
| if (!report) { | ||
| return false; | ||
| } | ||
|
|
||
| const header = report.header as Record<string, unknown> | undefined; | ||
| if (header && typeof header.glibcVersionRuntime === "string") { | ||
| return false; | ||
| } | ||
|
|
||
| const sharedObjects = report.sharedObjects as string[] | undefined; | ||
| if (Array.isArray(sharedObjects)) { | ||
| return sharedObjects.some( | ||
| (so) => so.includes("libc.musl-") || so.includes("ld-musl-") | ||
| ); | ||
| } | ||
|
|
||
| return false; | ||
| } catch { | ||
| return false; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| #!/bin/bash | ||
| set -e | ||
|
|
||
| if [ -z "$1" ]; then | ||
| echo "Error: Node.js version is required" | ||
| echo "Usage: bash scripts/test-alpine.sh <node-version>" | ||
| exit 1 | ||
| fi | ||
|
|
||
| NODE_VERSION="$1" | ||
|
|
||
| echo "Testing Zen on Alpine Linux (musl) with Node.js ${NODE_VERSION}..." | ||
|
|
||
| output=$(docker run --rm -e AIKIDO_DEBUG=true -w /app \ | ||
| -v "$(pwd)/build:/app/node_modules/@aikidosec/firewall" \ | ||
| "node:${NODE_VERSION}-alpine" \ | ||
| node -e "require('@aikidosec/firewall'); setTimeout(() => console.log('OK'), 1000);" 2>&1) | ||
hansott marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| echo "$output" | ||
|
|
||
| if echo "$output" | grep -q "Failed to load native addon"; then | ||
| echo "FAIL: Native addon failed to load on Alpine" | ||
| exit 1 | ||
| fi | ||
|
|
||
| if echo "$output" | grep -q "Cannot find native addon"; then | ||
| echo "FAIL: Native addon not found on Alpine" | ||
| exit 1 | ||
| fi | ||
|
|
||
| if echo "$output" | grep -q "OK"; then | ||
| echo "PASS: Zen loaded successfully on Alpine" | ||
| else | ||
| echo "FAIL: Zen did not load correctly on Alpine" | ||
| exit 1 | ||
| fi | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.