Improve support for IPv4 mapped IPv6 addresses#888
Merged
Conversation
When an IPMatcher is called frequently or the list is often short/empty, we should add the ranges when creating the IPMatcher instance (e.g. bypassed IPs) For bigger lists, we should convert the IP when checking (e.g. Geo lists or known threat actors)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The IPMatcher constructor calls summarizeSortedNetworks which has a bug when mixing IPv4 and IPv6 networks - it can incorrectly merge or drop networks during sorting/summarization. Using .add() for each IP avoids this issue as it inserts without summarization.
PopoviciMarian
approved these changes
Jan 16, 2026
The contains() method incorrectly returned true when the "other" network's next address overflowed (extends to end of address space). This caused 224.0.0.0/4.contains(240.0.0.0/4) to return true, preventing adjacent ranges from being merged correctly in summarizeSortedNetworks. See 482b0d9
timokoessler
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an IPMatcher is called frequently or the list is often short/empty, we should add the ranges when creating the IPMatcher instance (e.g. bypassed IPs)
For bigger lists, we should convert the IP when checking (e.g. Geo lists or known threat actors)
Summary by Aikido
🚀 New Features
⚡ Enhancements
🐛 Bugfixes
🔧 Refactors
More info