Skip to content

Adds more shell separators for injection check #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitterpanda63 merged 2 commits into from
Feb 6, 2026
Merged

Adds more shell separators for injection check #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb747bd
Also see \r \f amd \v as separators for shell injection
bitterpanda63 Feb 5, 2026
57d155f
remove the code for vertical tabs, this is not supported by most shells
bitterpanda63 Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rc/main/java/dev/aikido/agent_api/vulnerabilities/shell_injection/ShellSyntaxChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
public final class ShellSyntaxChecker {
private ShellSyntaxChecker() {}
private static final List<String> SEPARATORS = Arrays.asList(
" ", "\t", "\n", ";", "&", "|", "(", ")", "<", ">"
" ", "\t", "\n", ";", "&", "|", "(", ")", "<", ">", "\r", "\f"
);

public static boolean containsShellSyntax(String command, String userInput) {
Expand Down
14 changes: 14 additions & 0 deletions agent_api/src/test/java/vulnerabilities/shell_injection/ShellInjectionDetectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,4 +434,18 @@ void testItFlagsCommaInLoop() {
"for (( i=0, j=10; i<j; i++, j-- ))"
);
}

@Test
void testCarriageReturnAsSeparator() {
// \r (carriage return) as separator before dangerous command
assertIsShellInjection("ls\rrm", "rm");
assertIsShellInjection("echo test\rrm -rf /", "rm");
}

@Test
void testFormFeedAsSeparator() {
// \f (form feed) as separator before dangerous command
assertIsShellInjection("ls\frm", "rm");
assertIsShellInjection("echo test\frm -rf /", "rm");
}
}