refactor(quality): Rector wave 4 — collection, dead-code, readonly gate (AID-532)

[abkrim]

Fourth and final wave of the original plan. 6 app/ files, 6 insertions, 20 deletions. Resized with --clear-cache first: 4 + 3 files, overlap 1, combined 6.

Collection — equivalence verified per site

The three toArray() → all() rewrites all operate on collections of strings or plain arrays (table rows, filenames, multiselect options) — never Arrayable objects, where the two methods genuinely differ (toArray() recurses, all() does not). The filter(!empty) → reject(empty) rewrite moves the negation into the method choice without touching the predicate.

Dead-code — manual review, as the ticket required

• 2× SimplifyUselessVariable: trivial $marked = ...; return $marked → return ....
• 1× RemoveUnusedPrivateProperty on FirewallService: verified dead repo-wide — case-insensitive grep across app/, tests/, routes/, config/, database/ found zero callers of setModSecurityOutput() and the property is write-only. (A first case-sensitive grep missed the method name entirely — the re-check with -i is what makes the claim solid.)
• Hand finish: Rector only empties the orphan public setter, leaving public function setModSecurityOutput(string $output): void {} — a silent no-op promising to store state. Its docblock says "for testing", but no test calls it. The whole method was removed in the same wave. Suite stayed green, consistent with the zero-caller finding.

The two rules deferred from PR 0 both enter the gate — proven on both sides

Rule	Bites (probe)	Safe (contra-probe)
ReadOnlyClassRector	all-readonly app class → rc=2	Livewire component with only readonly props → rc=0 — a readonly class cannot extend a non-readonly parent and the rule honours it. The Filament/Livewire risk recorded at PR 0 is empirically refuted, not assumed away.
LARAVEL_TYPE_DECLARATIONS	Eloquent closure without hint → rc=2 (EloquentWhereTypeHintClosureParameterRector)	zero-diff on the current tree; its Builder hints are the ones that help larastan

Gates

Diff shape-verified (every changed line classified, none unexplained) · idempotent (second pass byte-level no-op) · composer check-full → exit 0, 1442 passed / 16 skipped, coverage 89.8% · refactor:dry (cleared cache) exit 0.