Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy command to copy index.html to 404.html #19

Merged
merged 2 commits into from
Aug 9, 2020
Merged

Add copy command to copy index.html to 404.html #19

merged 2 commits into from
Aug 9, 2020

Conversation

dutchmartin
Copy link
Contributor

Closes #9

@AhsanAyaz
Copy link
Owner

Thanks a bunch for the PR @dutchmartin . Will have a review, add the stuff to readme and will release an updated version.

@dutchmartin
Copy link
Contributor Author

I decided that adding extra logic to toggle the copying is not worth the extra amount of code it requires and thus set copying index.html to 404.html as a sane default. Please let me know what you think of this.

@dutchmartin dutchmartin marked this pull request as ready for review July 28, 2020 20:49
@AhsanAyaz AhsanAyaz merged commit 3831fbc into AhsanAyaz:master Aug 9, 2020
@dutchmartin dutchmartin mentioned this pull request Oct 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhsanAyaz AhsanAyaz AhsanAyaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create 404.html to handle redirection
2 participants
@dutchmartin @AhsanAyaz