base-href optional to support @angular/cli^10.0.0 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelnygaard
commented
Jul 1, 2020
There was a problem hiding this comment.
@AhsanAyaz If needed i can revert the formatting chances, it is just my auto formatting.
| @@ -44,17 +44,17 @@ You have to configure the `with` portion of your workflow file so that the actio | |||
|
|
|||
| | Key | Value Information | Type | Required | Default | | |||
| | -------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------- | -------- | -------- | | |||
| | `angular_project_dir` | The directory of the angular project, in which all the commands will run. This is super handy when you have several projects within a workspace. Or have a demo angular project within a library. Defaults to current workspace directory | `with` | **Yes** | "" | | |||
| | `angular_project_dir` | The directory of the angular project, in which all the commands will run. This is super handy when you have several projects within a workspace. Or have a demo angular project within a library. Defaults to current workspace directory | `with` | **Yes** | "./" | | |||
There was a problem hiding this comment.
This reflects the default values action.yml file
| baseHref = '/'; | ||
| let baseHrefString = ''; | ||
| if (baseHref && baseHref.length > 0) { | ||
| baseHrefString = '--base-href=' + baseHref; |
There was a problem hiding this comment.
Im basically just moving the appending into this if statement instead of at the end
|
Thanks for the PR @samuelnygaard 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since @angular/cli^10.0.0 have deprecated the base-href option for
ng buildand moved the configuration into theangular.jsonfile, this actions gives this errorUnknown option: '--base-href'when using a repo with Angular CLI version 10.There i made the base-href semi-optional, so if you give an empty string or a null value as the input parameter, the parameter
--base-href=/will not be appended to theng buildinstruction.I have tested it and i works in my Actions.