Skip to content

Commit

Permalink
staging: gdm72xx: Use net_device_stats from struct net_device
Browse files Browse the repository at this point in the history
Instead of using an own copy of struct net_device_stats in struct nic,
use stats from struct net_device. Also remove the thus unnecessary
.ndo_get_stats function, as it would now just return netdev->stats,
which is the default in dev_get_stats().

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
tklauser authored and gregkh committed Jul 9, 2014
1 parent 10ebe37 commit b92274e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 14 deletions.
17 changes: 4 additions & 13 deletions drivers/staging/gdm72xx/gdm_wimax.c
Original file line number Diff line number Diff line change
Expand Up @@ -360,8 +360,8 @@ int gdm_wimax_send_tx(struct sk_buff *skb, struct net_device *dev)
return ret;
}

nic->stats.tx_packets++;
nic->stats.tx_bytes += skb->len - HCI_HEADER_SIZE;
dev->stats.tx_packets++;
dev->stats.tx_bytes += skb->len - HCI_HEADER_SIZE;
kfree_skb(skb);
return ret;
}
Expand Down Expand Up @@ -433,13 +433,6 @@ static int gdm_wimax_set_mac_addr(struct net_device *dev, void *p)
return 0;
}

static struct net_device_stats *gdm_wimax_stats(struct net_device *dev)
{
struct nic *nic = netdev_priv(dev);

return &nic->stats;
}

static int gdm_wimax_open(struct net_device *dev)
{
struct nic *nic = netdev_priv(dev);
Expand Down Expand Up @@ -696,7 +689,6 @@ static int gdm_wimax_get_prepared_info(struct net_device *dev, char *buf,

static void gdm_wimax_netif_rx(struct net_device *dev, char *buf, int len)
{
struct nic *nic = netdev_priv(dev);
struct sk_buff *skb;
int ret;

Expand All @@ -709,8 +701,8 @@ static void gdm_wimax_netif_rx(struct net_device *dev, char *buf, int len)
}
skb_reserve(skb, 2);

nic->stats.rx_packets++;
nic->stats.rx_bytes += len;
dev->stats.rx_packets++;
dev->stats.rx_bytes += len;

memcpy(skb_put(skb, len), buf, len);

Expand Down Expand Up @@ -866,7 +858,6 @@ static struct net_device_ops gdm_netdev_ops = {
.ndo_stop = gdm_wimax_close,
.ndo_set_config = gdm_wimax_set_config,
.ndo_start_xmit = gdm_wimax_tx,
.ndo_get_stats = gdm_wimax_stats,
.ndo_set_mac_address = gdm_wimax_set_mac_addr,
.ndo_do_ioctl = gdm_wimax_ioctl,
};
Expand Down
1 change: 0 additions & 1 deletion drivers/staging/gdm72xx/gdm_wimax.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ struct phy_dev {
struct nic {
struct net_device *netdev;
struct phy_dev *phy_dev;
struct net_device_stats stats;
struct data_s sdk_data[SIOC_DATA_MAX];
#if defined(CONFIG_WIMAX_GDM72XX_QOS)
struct qos_cb_s qos;
Expand Down

0 comments on commit b92274e

Please sign in to comment.