Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config webpack bundle analysis #173

Merged
merged 2 commits into from
Apr 21, 2019
Merged

Conversation

HyunmoAhn
Copy link
Member

@HyunmoAhn HyunmoAhn commented Apr 20, 2019

Purpose

  • analysis bundle size using webpack-bundle-analysis
  • optimization about vendor using webpack config

Analysis

Before Optimization After Optimization
electron JS bundle 2.29MB 2.29MB
page JS bundle 2.25MB 1.01MB
Oh-my-desk install file(.dmg) 72.8MB 71.8MB
Oh-my-desk execute file(.dmg) 262.3MB 259.3MB

Description

page JS bundle has big decrease 55% of before. It is greatly decrease on web-page.
But I think that it is not grate decrease on desktop app like electron. Because all file is downloaded user. So, 2MB decrease is not big optimization.

Need to another improved package method.

@HyunmoAhn HyunmoAhn self-assigned this Apr 20, 2019
@coveralls
Copy link

coveralls commented Apr 21, 2019

Pull Request Test Coverage Report for Build 269

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.063%

Totals Coverage Status
Change from base Build 266: 0.0%
Covered Lines: 921
Relevant Lines: 1353

💛 - Coveralls

@HyunmoAhn HyunmoAhn force-pushed the refactor/webpack-optimizer branch from 32efa9a to c2e6ea1 Compare April 21, 2019 13:54
@HyunmoAhn HyunmoAhn merged commit d9dcc85 into develop Apr 21, 2019
@HyunmoAhn HyunmoAhn deleted the refactor/webpack-optimizer branch April 21, 2019 13:56
@HyunmoAhn HyunmoAhn mentioned this pull request Apr 21, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants