feat(noble): configuration to add noble testnet node and relayer on devnet #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mujahidkay
commented
Feb 10, 2025
Comment on lines
+72
to
+73
| relayer keys restore "$INTERNAL_CHAIN_NAME" user1 "cinnamon legend sword giant master simple visit action level ancient day rubber pigeon filter garment hockey stay water crawl omit airport venture toilet oppose" | ||
| relayer keys restore "$EXTERNAL_CHAIN_NAME" nobleuser1 "stamp later develop betray boss ranch abstract puzzle calm right bounce march orchard edge correct canal fault miracle void dutch lottery lucky observe armed" |
There was a problem hiding this comment.
instead of using mnemonics here I think we should env vars here and pass the actual values via configMapGenerator literals from private overlays
mujahidkay
commented
Feb 10, 2025
| INTERNAL_CHAIN_GAS_DENOM=${INTERNAL_CHAIN_GAS_DENOM:-ubld} | ||
| INTERNAL_CHAIN_ID=${INTERNAL_CHAIN_ID:-agoricdev-23} | ||
| INTERNAL_CHAIN_NAME=${INTERNAL_CHAIN_NAME:-agoric} | ||
| INTERNAL_CHAIN_RPC="https://devnet.rpc.agoric.net:443" |
There was a problem hiding this comment.
can only use devnet rpc as fallback - like other internal chain vars
mujahidkay
commented
Feb 10, 2025
| use_keys | ||
| add_path | ||
| start_relayer | ||
| sleep infinity No newline at end of file |
There was a problem hiding this comment.
not sure if this is still needed
| } | ||
|
|
||
| start_relayer() { | ||
| relayer start |
There was a problem hiding this comment.
I am thinking is it possible to be able to use a consistent channel?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR pushes the configuration changes needed for deploying a noble testnet node and relayer b/w agoric and itself