Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Separate logs backup script #80

Merged
merged 1 commit into from
Jan 3, 2025
Merged

chore: Separate logs backup script #80

merged 1 commit into from
Jan 3, 2025

Conversation

usmanmani1122
Copy link
Contributor

Description

This PR is a part of entrypoint refactoring effort and separate logs cleanup script

@usmanmani1122 usmanmani1122 self-assigned this Jan 2, 2025
Muneeb147
Muneeb147 reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@Muneeb147 Muneeb147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and clean.
Have we verified/deployed it on some test namespace?

@usmanmani1122
Copy link
Contributor Author

Looks good and clean. Have we verified/deployed it on some test namespace?

Yes
Tested this on testnet (namespace usman, cluster puffynet)

@usmanmani1122 usmanmani1122 merged commit 3458057 into main Jan 3, 2025
@usmanmani1122 usmanmani1122 deleted the usman/separate-logs-cleanup-script branch January 3, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Muneeb147 Muneeb147 Muneeb147 approved these changes

Assignees

@usmanmani1122 usmanmani1122

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usmanmani1122 @Muneeb147