Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cosmic-swingset should use disk-backed storage #900

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

warner
Copy link
Member

@warner warner commented Apr 9, 2020

We were still using swing-store-simple, which keeps the kernel state in
RAM. This is serialized to disk at the end of each block.

This switches it to our nice shiny swing-store-lmdb, which keeps the state on
disk at all times, only reading one key at a time into RAM.

closes #899

@warner warner added the cosmic-swingset package: cosmic-swingset label Apr 9, 2020
@warner warner requested a review from FUDCo April 9, 2020 16:16
@warner warner self-assigned this Apr 9, 2020
@warner warner requested a review from michaelfig April 9, 2020 17:34
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We were still using swing-store-simple, which keeps the kernel state in
RAM. This is serialized to disk at the end of each block.

This switches it to our nice shiny swing-store-lmdb, which keeps the state on
disk at all times, only reading one key at a time into RAM.

closes #899
@warner warner merged commit da0613a into master Apr 9, 2020
@warner warner deleted the 899-cosmic-use-db branch April 9, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmic-swingset package: cosmic-swingset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch cosmic-swingset to use LMDB for kernel storage
2 participants