fix: handle Node 18 breaking change #8600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
approved these changes
Dec 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8599
Description
Cherry-picks endojs/endo#1579 as a patch on
sesto work around the breaking change in Node 18.19This results in a different xsnap lockdown bundle, but with minimal non-observable changes in vats.
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Tests pull latest node 18 pass.
Upgrade Considerations
This must be released as part of a chain software upgrade. Vats started after this change will use a new lockdown bundle.