-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(agoric-cli): Add agoric publish subcommand #6147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 7, 2022 00:07
b13dff7
to
3a08ef2
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 7, 2022 00:07
cc35b0d
to
e8c9346
Compare
Ack. I defer to other reviewers. Glad to see progress here. |
dckc
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 7, 2022 20:16
3a08ef2
to
fff7129
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 7, 2022 20:16
e8c9346
to
c20ff15
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 7, 2022 22:42
fff7129
to
8e4054e
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 7, 2022 22:42
c20ff15
to
3797538
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 7, 2022 22:56
8e4054e
to
48787e0
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 7, 2022 22:56
3797538
to
912bbf9
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 7, 2022 23:13
48787e0
to
a93cc67
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 7, 2022 23:13
912bbf9
to
0ccee94
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 7, 2022 23:42
a93cc67
to
02a1906
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 7, 2022 23:42
0ccee94
to
ce11341
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 8, 2022 01:12
02a1906
to
4898349
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 8, 2022 01:12
ce11341
to
17be397
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 8, 2022 01:33
4898349
to
9ca8aef
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 8, 2022 01:33
17be397
to
d1b7602
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 8, 2022 02:09
9ca8aef
to
1387dc8
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 8, 2022 02:09
d1b7602
to
7adf69a
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 8, 2022 02:10
1387dc8
to
5dd9f7a
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 8, 2022 02:10
7adf69a
to
e1d72d6
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 8, 2022 16:20
5dd9f7a
to
f56a59a
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 8, 2022 16:20
e1d72d6
to
98a0ee8
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 8, 2022 17:33
f56a59a
to
2e08022
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 8, 2022 17:33
98a0ee8
to
8b66928
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 9, 2022 00:15
2e08022
to
1bc4d9c
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 9, 2022 00:15
8b66928
to
4876332
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 9, 2022 00:16
1bc4d9c
to
1319af3
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 9, 2022 00:16
4876332
to
953e4c5
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 9, 2022 00:44
1319af3
to
5f354c6
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 9, 2022 00:44
953e4c5
to
535855e
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 12, 2022 20:01
5f354c6
to
f186294
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 12, 2022 20:01
535855e
to
b984491
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 12, 2022 21:47
f186294
to
c965dee
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 12, 2022 21:47
b984491
to
654486b
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 12, 2022 23:04
c965dee
to
5994ad8
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 12, 2022 23:04
654486b
to
92bdf9b
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 13, 2022 18:32
5994ad8
to
2c7d34f
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 13, 2022 18:32
92bdf9b
to
0d39b2c
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 13, 2022 18:35
2c7d34f
to
50306d7
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 13, 2022 18:35
0d39b2c
to
cd1267e
Compare
kriskowal
force-pushed
the
5618-publish-bundle-helper
branch
from
September 13, 2022 20:51
50306d7
to
95d34b5
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 13, 2022 20:51
cd1267e
to
cacde18
Compare
kriskowal
force-pushed
the
6087-agoric-publish-command
branch
from
September 13, 2022 20:57
cacde18
to
b4a8c7d
Compare
kriskowal
changed the base branch from
5618-publish-bundle-helper
to
master
September 13, 2022 20:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge:rebase
Automatically rebase updates, then merge
force:integration
Force integration tests to run on PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #6087
Description
This is an
agoric publish
command that can post directly to the chain and return a hash bundle JSON blob, suitable for passing tozoe~.install
.Security Considerations
Documentation Considerations
This will be useful for documenting governance #6086
Testing Considerations
Works on my machine. To make work on your machine:
In cosmic-swingset:
In another cosmic-swingset, use an ag-solo to provision an account. You may then turn off the ag-solo: it is not needed, and later commands must not depend on it.
In
dapp-fungible-faucet
, prepare a bundle.json:By whatever string-carving you prefer, convert the generated
bundles/bundle-contract.js
tobundles/bundle-contract.json
. A small Node script that imports the JS and writes out JSON will suffice, or just removing theexport default
prefix and;
suffix in an editor will work too.Continue:
You can verify the publish with agoric follow: (the flags just provide block height published, block height observed, and ensure one line per publish).
You can also confirm with agd: