Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel GC breakage #3562

Closed
erights opened this issue Jul 29, 2021 · 2 comments
Closed

Kernel GC breakage #3562

erights opened this issue Jul 29, 2021 · 2 comments
Assignees
Labels
bug Something isn't working SwingSet package: SwingSet

Comments

@erights
Copy link
Member

erights commented Jul 29, 2021

@FUDCo , after rebase-ing #3525 to current master, I still get the following error:

  test/virtualObjects/test-representatives.js:469

   468:   }                                                                     
   469:   t.deepEqual(remainingVOs, {                                           
   470:     'v1.vs.vom.o+1/2': '{"label":{"body":"\\"thing #2\\"","slots":[]}}',

  Difference:

    {
      'v1.vs.vom.o+1/2': '{"label":{"body":"\\"thing #2\\"","slots":[]}}',
  +   'v1.vs.vom.o+1/2.refCount': '0 0',
      'v1.vs.vom.o+1/3': '{"label":{"body":"\\"thing #3\\"","slots":[]}}',
  -   'v1.vs.vom.o+1/4': '{"label":{"body":"\\"thing #4\\"","slots":[]}}',
  -   'v1.vs.vom.o+1/5': '{"label":{"body":"\\"thing #5\\"","slots":[]}}',
  -   'v1.vs.vom.o+1/6': '{"label":{"body":"\\"thing #6\\"","slots":[]}}',
  +   'v1.vs.vom.o+1/3.refCount': '1 0',
  +   'v1.vs.vom.o+1/8': '{"label":{"body":"\\"thing #8\\"","slots":[]}}',
  +   'v1.vs.vom.o+1/9': '{"label":{"body":"\\"thing #9\\"","slots":[]}}',
    }

  › test/virtualObjects/test-representatives.js:469:5

See https://github.com/Agoric/agoric-sdk/pull/3525/checks?check_run_id=3196077205
and https://github.com/Agoric/agoric-sdk/pull/3525/checks?check_run_id=3196077794

This PR used to work on a very recent master, so the kernel gc problem is new.

@erights erights added the bug Something isn't working label Jul 29, 2021
@erights erights added the SwingSet package: SwingSet label Jul 29, 2021
@erights
Copy link
Member Author

erights commented Jul 29, 2021

Note that the PR is a one line change, so it is trivial to try it out on whatever instrumented version you have.

@FUDCo
Copy link
Contributor

FUDCo commented Jul 31, 2021

Closed by #3566

@FUDCo FUDCo closed this as completed Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SwingSet package: SwingSet
Projects
None yet
Development

No branches or pull requests

3 participants