Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slogger has off-by-one in slogging of deliveryNum #3022

Closed
FUDCo opened this issue May 4, 2021 · 1 comment
Closed

Slogger has off-by-one in slogging of deliveryNum #3022

FUDCo opened this issue May 4, 2021 · 1 comment
Assignees
Labels
bug Something isn't working SwingSet package: SwingSet

Comments

@FUDCo
Copy link
Contributor

FUDCo commented May 4, 2021

Describe the bug

An incidental discover in the examination of #3021 is that the slogger increments deliveryNum before it is done outputting all the slog entries generated in the processing of a delivery, the result of which is that while the entry for the delivery itself as well as the delivery result at the end shows the correct delivery number, all the slog entries framed by these show a delivery number one greater.

This is disambiguated by context when all slog entries are read in chronological order, but if a filter was applied just to extract selected entries, this context might not be present.

To Reproduce

Turn on slogging, send some messages that produce activity, examine the deliveryNum field in slog entries that contain one.

Expected behavior

The deliveryNum value in slog entries should match the delivery number of the delivery they are describing.

@FUDCo FUDCo added the bug Something isn't working label May 4, 2021
@FUDCo FUDCo self-assigned this May 7, 2021
@FUDCo FUDCo added the SwingSet package: SwingSet label May 7, 2021
@FUDCo FUDCo mentioned this issue May 8, 2021
@FUDCo
Copy link
Contributor Author

FUDCo commented May 11, 2021

Closed by #3059

@FUDCo FUDCo closed this as completed May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SwingSet package: SwingSet
Projects
None yet
Development

No branches or pull requests

1 participant