Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-worker needs to exercise more of the kernel-worker protocol #1778

Closed
warner opened this issue Sep 16, 2020 · 1 comment
Closed

test-worker needs to exercise more of the kernel-worker protocol #1778

warner opened this issue Sep 16, 2020 · 1 comment
Assignees
@warner
Labels
enhancement New feature or request SwingSet package: SwingSet

Comments

@warner
Copy link
Member

warner commented Sep 16, 2020

While reviewing code with @dckc , we noticed problems (#1775) that were not being exercised by test-worker.js. In particular, we need to make sure we send both ['deliver', 'message'] and ['deliver', 'notify'], along with all of the possible syscalls. The test was apparently only exercising the message case.
@warner warner added enhancement New feature or request SwingSet package: SwingSet labels Sep 16, 2020
@warner warner self-assigned this Jan 12, 2021
@warner
Copy link
Member Author

warner commented Jan 19, 2021

It looks like the test was indeed exercising notify, but I'm updating it to confirm that the data included in those deliveries is correct (previously we were merely checking that the kernel and worker didn't crash).

warner added a commit that referenced this issue Jan 19, 2021
@warner
fix: improve test-worker.js to assert promise results are correct
d214cb7 
Also hush some console messages, and test the local worker as well (for
parallelism).

closes #1778
dckc pushed a commit that referenced this issue Jan 21, 2021
@warner @dckc
fix: improve test-worker.js to assert promise results are correct
320c8fd 
Also hush some console messages, and test the local worker as well (for
parallelism).

closes #1778
dckc pushed a commit to dckc/agoric-sdk that referenced this issue Jan 21, 2021
@warner @dckc
fix: improve test-worker.js to assert promise results are correct
c72cfd6 
Also hush some console messages, and test the local worker as well (for
parallelism).

closes Agoric#1778
@dckc dckc closed this as completed in 73487b1 Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warner warner

Labels
enhancement New feature or request SwingSet package: SwingSet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@warner