disable XS test (temporarily) #1251
Assignees
Labels
tooling
repo-wide infrastructure
Comments
warner
added a commit
that referenced
this issue
Jul 2, 2020
We learned (in #1244) that the XS RegExp engine rejects several of the regexp literals that appear in the SES shim (via babel-standalone). The XS test works by compiling some other unit tests (eventual-send and marshal) into a C executable, then running it. #1244 added `install-ses` to most packages, including those two, which means XS is now being exposed to SES-shim code that it wasn't seeing before, triggering the rejection bug. When XS is updated to tolerate these cases, we'll turn this test back on. closes #1251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@FUDCo discovered (in #1244) that the XS RegExp engine rejects several of the regexp literals that appear in the
babel-standalonepackage, which are included in the SES shim. His PR was the first time the XS parser had to look at the SES shim code.The Moddable folks are looking into it, but until we've got a version of XS that tolerates these, I think we should disable our XS test so that we can land #1244 . We thought briefly about modifying our fork (
@agoric/babel-standalone), but two of the regexps are coming from other upstream libraries, so we'd have to fork too much to make that work.We can reenable this test when XS is updated.
The text was updated successfully, but these errors were encountered: