Skip to content

Commit

Permalink
chore(swingset): re-enable test of unrecognizable orphan cleanup (#8694)
Browse files Browse the repository at this point in the history
This clause was commented out because bug #3378 was still pending at the time. I think we happened to fix that as a side-effect of adding `syscall.abandonExport` for #4951 (in PR #4957), but didn't realize we could re-enable the clause.

closes #3378
  • Loading branch information
mergify[bot] authored Jun 14, 2024
2 parents a2e54e1 + 9930bd3 commit bc53ef7
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions packages/SwingSet/test/gc-kernel.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1165,9 +1165,7 @@ test('terminated vat', async t => {
// t.is(refcounts[doomedExport1Kref], undefined);
t.falsy(owners[doomedExport1Kref]);

// TODO: we still fail to clean up the [0,0] kref: #3378 is about finding
// somewhere to delete the .refcount key
// t.is(refcounts[doomedExport2Kref], undefined);
t.is(refcounts[doomedExport2Kref], undefined);
t.falsy(owners[doomedExport2Kref]);
});

Expand Down

0 comments on commit bc53ef7

Please sign in to comment.