fix: minor tweaks for dapp-oracle

Agoric · Nov 8, 2020 · b8169c1 · b8169c1
1 parent 0c18aae
commit b8169c1
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/packages/agoric-cli/lib/start.js b/packages/agoric-cli/lib/start.js
@@ -34,7 +34,7 @@ export default async function startMain(progname, rawArgs, powers, opts) {
     cargs,
     { stdio = 'inherit', env = pspawnEnv, ...rest } = {},
   ) => {
-    log.debug(chalk.blueBright(cmd, ...cargs));
+    log(chalk.blueBright(cmd, ...cargs));
     const cp = spawn(cmd, cargs, { stdio, env, ...rest });
     const pr = new Promise((resolve, _reject) => {
       cp.on('exit', resolve);
@@ -56,7 +56,7 @@ export default async function startMain(progname, rawArgs, powers, opts) {
           'run',
           `--volume=${process.cwd()}:/usr/src/dapp`,
           `--rm`,
-          `-it`,
+          // `-it`,
           `--entrypoint=ag-cosmos-helper`,
           'agoric/agoric-sdk',
           `--home=/usr/src/dapp/_agstate/keys`,
@@ -211,7 +211,7 @@ export default async function startMain(progname, rawArgs, powers, opts) {
             `--volume=${process.cwd()}:/usr/src/dapp`,
             `--rm`,
             ...dockerArgs,
-            `-it`,
+            // `-it`,
             SDK_IMAGE,
             ...args,
             `--home=/usr/src/dapp/${agServer}`,
@@ -298,7 +298,7 @@ export default async function startMain(progname, rawArgs, powers, opts) {
       if (exitStatus) {
         return exitStatus;
       }
-      exitStatus = await fs.writeFile(`${genesisFile}.stamp`, Date.now());
+      exitStatus = await fs.writeFile(`${genesisFile}.stamp`, `${Date.now()}`);
       if (exitStatus) {
         return exitStatus;
       }
@@ -383,7 +383,7 @@ export default async function startMain(progname, rawArgs, powers, opts) {
             `--volume=${process.env.HOME}/.agoric:/root/.agoric`,
             `-eAG_SOLO_BASEDIR=/usr/src/dapp/${agServer}`,
             `--rm`,
-            `-it`,
+            // `-it`,
             `--entrypoint=/usr/src/app/bin/ag-solo`,
             ...dockerArgs,
             SOLO_IMAGE,

diff --git a/packages/marshal/src/marshal.js b/packages/marshal/src/marshal.js
@@ -21,7 +21,7 @@ export { mustPassByRemote as mustPassByPresence };
  */
 const remotableToInterface = new WeakMap();
 
-/** @type {GetInterfaceOf} */
+/** @type {MarshalGetInterfaceOf} */
 export function getInterfaceOf(maybeRemotable) {
   return remotableToInterface.get(maybeRemotable);
 }

diff --git a/packages/marshal/src/types.js b/packages/marshal/src/types.js
@@ -139,7 +139,7 @@
  */
 
 /**
- * @callback GetInterfaceOf
+ * @callback MarshalGetInterfaceOf
  * Simple semantics, just tell what interface (or undefined) a remotable has.
  *
  * @param {*} maybeRemotable the value to check

diff --git a/packages/zoe/src/contracts/exported.js b/packages/zoe/src/contracts/exported.js
@@ -185,7 +185,7 @@
 /**
  * @typedef {Object} OracleHandler
  * @property {(query: any, fee: Amount) => Promise<{ reply:
- * any, requiredFee: Amount }>} onQuery callback to reply to a query
+ * any, requiredFee: Amount | undefined }>} onQuery callback to reply to a query
  * @property {(query: any, reason: any) => void} onError notice an error
  * @property {(query: any, reply: any, requiredFee: Amount) => void} onReply
  * notice a successful reply