Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci fix #1043

Merged
merged 9 commits into from
Aug 16, 2022
Merged

Ci fix #1043

merged 9 commits into from
Aug 16, 2022

Conversation

scottwn
Copy link
Contributor

@scottwn scottwn commented Aug 16, 2022 •
edited
Loading

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@scottwn scottwn requested review from a team as code owners August 16, 2022 14:42
@scottwn
Copy link
Contributor Author

scottwn commented Aug 16, 2022

pre-commit.ci autofix

@codecov
Copy link

codecov bot commented Aug 16, 2022 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.25%. Comparing base (f32d98d) to head (e4095c1).
Report is 495 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1043   +/-   ##
========================================
  Coverage    86.25%   86.25%           
========================================
  Files           60       60           
  Lines         3813     3813           
========================================
  Hits          3289     3289           
  Misses         524      524
Flag Coverage Δ
Dispatcher 74.27% <ø> (ø)
Functional_Tests 63.88% <ø> (ø)
SDK 80.30% <ø> (ø)

wjcunningham7
wjcunningham7 previously approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@wjcunningham7 wjcunningham7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very pretty

@wjcunningham7
Copy link
Member

pre-commit.ci autofix

@wjcunningham7
Copy link
Member

@scottwn looks like detect-secrets hook is complaining about secret inheritance in the workflows

@wjcunningham7 wjcunningham7 self-requested a review August 16, 2022 18:00
@wjcunningham7 wjcunningham7 enabled auto-merge (squash) August 16, 2022 18:01
@wjcunningham7 wjcunningham7 merged commit b0d4b2e into develop Aug 16, 2022
@wjcunningham7 wjcunningham7 deleted the ci-fix branch August 16, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjcunningham7 wjcunningham7 wjcunningham7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottwn @wjcunningham7