Skip to content

Commit

Permalink
TimeBlock accessibility
Browse files Browse the repository at this point in the history
closes CNVS-19314

refs CNVS-15543

This applies a screenreader-only label to the date picker and
timepickers used in the scheduler, and some KB-only user tooltips
(though they are visible for all users).  The goal is to make
it clear what format to input dates and times in to users
for whom the rich selector isn't so great.

TEST PLAN:
- go to the scheduler (make sure scheduler is enabled, go to calendar,
   use scheduler menu)
- schedule an appointment group
- Using a screenreader with your eyes closed, ensure you can figure out
  what date format to submit for the appointment group with no
  other context.  Same for time fields next to it.
- tab through to the same fields and prove that you see
  a little tooltip telling you what format to enter the date and time
in.

Change-Id: Idce5cdcfc4169ee538083d745ddd44de67bf6846
Reviewed-on: https://gerrit.instructure.com/50859
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
QA-Review: Steven Shepherd <sshepherd@instructure.com>
Product-Review: Ethan Vizitei <evizitei@instructure.com>
  • Loading branch information
evizitei committed Mar 25, 2015
1 parent 5237cdf commit 3d180c1
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions app/views/jst/calendar/TimeBlockRow.handlebars
Original file line number Diff line number Diff line change
@@ -1,16 +1,24 @@
<tr {{#if locked}}class="locked"{{/if}}>
<td class="date-column">
<input name="date" class="date_field" value="{{tDateToString start "medium_with_weekday"}}"
aria-label="{{t "date_label" "Date"}}" {{#if locked}}disabled{{/if}} type="text"/>
<input name="date" class="date_field"
value="{{tDateToString start "medium_with_weekday"}}"
aria-label="{{t "date_label" "Date"}}{{datepickerScreenreaderPrompt 'date'}}"
{{#if locked}}disabled{{/if}} type="text"
data-tooltip title="{{accessibleDateFormat 'date'}}"/>
</div>
</td>
<td class="start-time-column">
<input name="start_time" class="time_field start_time" value="{{tTimeToString start "tiny"}}"
aria-label="{{t "start_time_label" "Start Time"}}"{{#if locked}} disabled{{/if}} type="text"/>
aria-label="{{t "start_time_label" "Start Time"}}{{datepickerScreenreaderPrompt 'time'}}"
{{#if locked}} disabled{{/if}} type="text"
data-tooltip title="{{accessibleDateFormat 'time'}}"/>
</td>
<td class="separator-column">-</td>
<td class="end-time-column">
<input name="end_time" class="time_field end_time" value="{{tTimeToString end "tiny"}}"
aria-label="{{t "end_time_label" "End Time"}}"{{#if locked}} disabled{{/if}} type="text"/>
aria-label="{{t "end_time_label" "End Time"}}{{datepickerScreenreaderPrompt 'time'}}"
{{#if locked}} disabled{{/if}} type="text"
data-tooltip title="{{accessibleDateFormat 'time'}}"/>
</td>
<td class="delete-column">
{{#unless locked}}
Expand Down

0 comments on commit 3d180c1

Please sign in to comment.