fix(runner): raise total run deadline to 24 hours - #6091
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan includes up to 8 reviews per rolling hour; 7 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe runner total deadline increased from 45 minutes to 24 hours. Enterprise and OSS environment examples now show the new default. ACP timeout comments and run-limit tests were updated. ChangesRunner deadline configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The default total run deadline increases to 24 hours while existing idle and per-call limits remain in place; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
QA evidenceVideo proof: https://www.browserbase.com/sessions/4a764652-f078-471b-a3ea-4b7ef732161b Tested commit: Deployed image:
Additional checks:
Cleanup completed: both Browserbase sessions stopped, exe.dev restored to private, and the temporary SSH key was revoked and proved unusable. The exact PR runner image remains deployed for review. |
Railway Preview Environment
|
Long agent runs still making progress were aborted after 45 minutes with
total run deadline of 2700000ms exceeded.This raises the default total deadline to 24 hours. The idle, first-response, and per-tool-call limits continue to reclaim stalled runs. Deployments can still set
AGENTA_RUNNER_RUN_TOTAL_TIMEOUT_MSto a different positive millisecond value.The OSS and Enterprise Edition environment examples now show the 24-hour default.
Fixes #6084
Tests
pnpm exec vitest run tests/unit/run-limits.test.ts(13 passed)pnpm run typecheckpnpm test(complete runner unit suite passed)git diff --checkHow to review
services/runner/src/engines/sandbox_agent/run-limits.tsfor the default change.services/runner/tests/unit/run-limits.test.tsfor the former 45-minute regression case and override coverage.acp-fetch.tscomment update, which keeps its explanation accurate after the total deadline increases.