Skip to content

#3755 fix(SDK, frontend): Exclude parameters from trace inputs in chat/completion/hook handlers#3756

Merged
jp-agenta merged 2 commits intorelease/v0.85.6from
feat/parameters-in-inputs
Feb 14, 2026
Merged

#3755 fix(SDK, frontend): Exclude parameters from trace inputs in chat/completion/hook handlers#3756
jp-agenta merged 2 commits intorelease/v0.85.6from
feat/parameters-in-inputs

Conversation

@mmabrouk
Copy link
Member

@mmabrouk mmabrouk commented Feb 13, 2026

Summary

  • Adds ignore_inputs=["parameters"] to the @instrument() decorator on completion_v0, chat_v0, and hook_v0 so that configuration parameters are no longer incorrectly captured inside ag.data.inputs
  • Fixes the ignore_inputs/ignore_outputs type hints on the instrument class to accept Union[bool, List[str]], matching the actual _redact implementation
  • Removes the frontend workaround in getAgDataInputs that was manually stripping parameters from the inputs object before display

Closes #3755


Open with Devin

…k handlers

Use ignore_inputs=["parameters"] on the @Instrument() decorator for
completion_v0, chat_v0, and hook_v0 so that the configuration parameters
are no longer captured inside ag.data.inputs.

Also fix the ignore_inputs/ignore_outputs type hints on the instrument
class to accept Union[bool, List[str]] matching the actual _redact
implementation.

Remove the frontend workaround in getAgDataInputs that was stripping
parameters from inputs before display.

Closes #3755
@mmabrouk mmabrouk added bug Something isn't working Frontend Backend SDK labels Feb 13, 2026
@vercel
Copy link

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment Feb 14, 2026 1:49pm

Request Review

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 13, 2026
@mmabrouk mmabrouk requested a review from jp-agenta February 13, 2026 17:52
@mmabrouk
Copy link
Member Author

Tested locally and working

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 4 additional findings in Devin Review.

Open in Devin Review

@jp-agenta jp-agenta changed the base branch from main to release/v0.85.6 February 14, 2026 13:48
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 14, 2026
@jp-agenta jp-agenta merged commit bf340da into release/v0.85.6 Feb 14, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backend bug Something isn't working Frontend lgtm This PR has been approved by a maintainer SDK size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trace inputs incorrectly include parameters for chat/completion/hook services

2 participants