Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames agenta app Dockerfiles to non-trivial names #1739

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mmabrouk
Copy link
Member

@mmabrouk mmabrouk commented Jun 2, 2024

Closes #1738

Please QA

Copy link

vercel bot commented Jun 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 0:18am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 0:18am

@mmabrouk
Copy link
Member Author

mmabrouk commented Aug 9, 2024

@aybruhm It is expected that the oss tests fail here, since they are using the old backend hosted in oss.agenta.ai (which expects Dockerfile and not Dockerfile.agenta.oss).

The QA therefore needs to test these manually:

  • New SDK on new OSS backend
  • New SDK on new Cloud Backend
  • Old SDK on new OSS backend
  • Old SDK on new Cloud backend

We do not need to test new sdk on old backend (Since that should not work).

In the future, I think we need to move the dockerfile creation to the backend. It's just nice to have it in the FE for debugging for now (although, not sure if this is used at all).

@aybruhm
Copy link
Member

aybruhm commented Aug 9, 2024

@aybruhm It is expected that the oss tests fail here, since they are using the old backend hosted in oss.agenta.ai (which expects Dockerfile and not Dockerfile.agenta.oss)

Ah, got it. 😅 Thank you for clarifying.

@mmabrouk
Copy link
Member Author

mmabrouk commented Aug 9, 2024

@aybruhm updated the comment

@mmabrouk
Copy link
Member Author

mmabrouk commented Aug 9, 2024

@aybruhm I have also reverted the change you made, it looks to me that it introduces and error

@aybruhm
Copy link
Member

aybruhm commented Aug 9, 2024

@aybruhm I have also reverted the change you made, it looks to me that it introduces and error

🤔

Copy link
Contributor

@jp-agenta jp-agenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to move all the serve operations and files inside of a .agenta folder to avoid any conflicts.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2024
@aybruhm
Copy link
Member

aybruhm commented Nov 14, 2024

We might want to move all the serve operations and files inside of a .agenta folder to avoid any conflicts.

I'm not sure if I understand what you mean.

Copy link
Member

@aybruhm aybruhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @mmabrouk ! I've QA'ed oss and cloud staging with the changes, and everything looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend CLI lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AGE-230] [Bug] Start from code can fail if user has a .dockerignore or Dockerfile
3 participants