Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the add new evaluation modal #1407

Merged
merged 9 commits into from
Feb 25, 2024

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Feb 22, 2024

Issue #1392

@bekossy bekossy linked an issue Feb 22, 2024 that may be closed by this pull request
@aakrem
Copy link
Collaborator

aakrem commented Feb 23, 2024

@bekossy can you format the code please ?

cd agenta-backend
black .

Copy link
Collaborator

@aakrem aakrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @bekossy it looks cool!
Small adjustments:

  1. Let's make the search results updated while we type.
  2. If we type in the search input then exit the modal then open it again the word we typed remains there
  3. After we type something then we save we see only the previous results in the list of evalutators

@bekossy
Copy link
Member Author

bekossy commented Feb 25, 2024

Screen Shot 2024-02-25 at 11 08 42 AM

Thanks for the review @aakrem
Could you checkout to my branch and check if you are able to format the code? Thanks!

merge main into issue-1392/-Improving-the-add-new-evaluation-modal
@aakrem
Copy link
Collaborator

aakrem commented Feb 25, 2024

@bekossy, I fixed the format.
Now one last thing I have found is that when we close an evaluator modal it doesn't work; when we edit and when we create.
Screenshot 2024-02-25 at 15 32 05
Screenshot 2024-02-25 at 15 31 50

Copy link
Collaborator

@aakrem aakrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reaally cool @bekossy thank you for the PR!!

@aakrem aakrem merged commit 64f6847 into main Feb 25, 2024
8 checks passed
@aakrem aakrem deleted the issue-1392/-Improving-the-add-new-evaluation-modal branch February 25, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] Improving the add new evaluation modal
2 participants