Skip to content

Conversation

tcdent
Copy link
Contributor

@tcdent tcdent commented Mar 25, 2025

Update attribute extraction to support dict as well as object.

Addresses #886

@tcdent tcdent requested a review from dot-agi March 25, 2025 20:09
@dot-agi
Copy link
Member

dot-agi commented Mar 25, 2025

Unit tests failing - culprit is in the openai tests.

… encode in tests to handle MagicMock objects.
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...strumentation/openai_agents/attributes/__init__.py 87.50% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@tcdent
Copy link
Contributor Author

tcdent commented Mar 25, 2025

Tests pass now. We blew up the type checker with the LangGraph merge :/

@dot-agi
Copy link
Member

dot-agi commented Mar 25, 2025

@dot-agi dot-agi merged commit 2c7b3a7 into main Mar 25, 2025
8 of 10 checks passed
@dot-agi dot-agi deleted the fix-openai-agents-counts branch March 25, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants