-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinecone Native Integration #485
base: main
Are you sure you want to change the base?
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | - | Generic High Entropy Secret | 4570e65 | agentops/llms/pinecone_test.py | View secret |
- | - | Generic High Entropy Secret | 5b0a5b1 | agentops/llms/pinecone_test.py | View secret |
- | - | Generic High Entropy Secret | 5b0a5b1 | agentops/llms/pinecone_test.py | View secret |
- | - | Generic High Entropy Secret | 4570e65 | agentops/llms/pinecone_test.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Amazing-- this is actually the first vectorDB integration PR we've seen so far. Will take a look soon @monami44. In the meantime-- can you resolve the merge conflict? |
Hey @areibman , I just resolved the merge conflict. Also here is a video-walkthrough I sent to Adam as I submitted the PR. Hit me up if you want anything else to be changed |
Super cool! @the-praxs and I can take a look |
Pinecone Integration with Comprehensive Testing Suite
Overview
This PR introduces a comprehensive Pinecone integration along with extensive testing coverage across vector operations, RAG implementations, inference capabilities, and assistant functionalities.
Key Features
PineconeProvider
ClassTesting Suites
RAG Pipeline Test (
pinecone_rag_test.py
)Inference API Test (
pinecone_inference_test.py
)Assistant API Test (
pinecone_assistant_test.py
)Implementation Details
Testing Instructions
Ensure that the required environment variables are set:
PINECONE_API_KEY
OPENAI_API_KEY
(for RAG testing)Run individual test suites with the following commands:
Notes
Future Improvements
For more information, refer to the Pinecone Documentation.