Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing job_posting and calling end_session in notebook automation #390

Merged
merged 7 commits into from
Sep 17, 2024

Conversation

HowieG
Copy link
Contributor

@HowieG HowieG commented Sep 14, 2024

📥 Pull Request

📘 Description
job_posting was failing automation because of same StdInNotImplementedError as previous change
Also calling end_session() so they don't come up as failures in dashboard

🧪 Testing
run notebook automation

Thank you for your contribution to Agentops!

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 44.32% <ø> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@siyangqiu siyangqiu merged commit 8161133 into main Sep 17, 2024
12 of 13 checks passed
@siyangqiu siyangqiu deleted the notebook-automation-fix branch September 17, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants