Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable AgentOps flag #387

Closed

Conversation

heethjain21
Copy link
Contributor

@heethjain21 heethjain21 commented Sep 13, 2024

📥 Pull Request

📘 Description

  • Added is_disabled flag during init() which is further passed to the Client config
  • Added global enable() and disable() functions to perform the same
  • When is_disabled is set to True, all sessions, event recording are disabled
  • Updated docs for the same

🔄 Related Issue (if applicable)
Create a way to disable AgentOps functions entirely #349

🎯 Goal

  • Add a global way to disable AgentOps completely with a flag

🔍 Additional Context

  • None

🧪 Testing

  • Added test cases for sessions, canary (wasn't sure if it was needed here), record_actions, record_tools

@heethjain21
Copy link
Contributor Author

Add reviewers option is not available for me, so tagging instead: @areibman @HowieG

Side Notes:

  • All old and new tests pass (using pytest)
  • Test Notebooks seems to be failing for other PRs too (and I haven't made any changes in that part)

@HowieG
Copy link
Contributor

HowieG commented Sep 18, 2024

Hey @heethjain21 thanks I think the team took a look and didn't feel we needed this @areibman @siyangqiu lmk

@siyangqiu
Copy link
Contributor

Yes. I agree with Howard. Thanks for putting in this work though

@heethjain21
Copy link
Contributor Author

heethjain21 commented Sep 19, 2024

Ahh nvm.

Could you also please also close the issues (like these), so it doesn't create confusion again in the future?

Edit 1: Closing the PR

Edit 2: Checked the Issue has been closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants