Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support to skip crew ending sessions automatically #231

Merged
merged 4 commits into from
May 30, 2024

Conversation

bboynton97
Copy link
Contributor

Closes #198

Crew has the ability to automatically detect when all tasks are complete and to end execution. If the developer doesn't wish for their AgentOps session to end at this time, they can pass an optional parameter into init() to skip this.

agentops/client.py Show resolved Hide resolved
@HowieG
Copy link
Contributor

HowieG commented May 30, 2024

Approving but I think our init params are getting too long and gut tells me we could do this cleaner. Discussed w @siyangqiu and we're all gonna discuss moving over to a config object pattern

@bboynton97
Copy link
Contributor Author

Approving but I think our init params are getting too long and gut tells me we could do this cleaner. Discussed w @siyangqiu and we're all gonna discuss moving over to a config object pattern

I would agree with this, but I think it merits more discussion unrelated to this PR

@bboynton97 bboynton97 merged commit cf599cf into main May 30, 2024
7 checks passed
@bboynton97 bboynton97 deleted the skip-auto-end-session branch May 30, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the option for Crews to not automatically end_session() after kickoff
2 participants