Skip to content

Conversation

@AyushAnand413
Copy link
Contributor

Hi @Agent-Hellboy ,

I've manually reviewed the test suite and removed redundancy as requested in issue #13.

Here are my changes:

  • Merged test_spew_config_default_values into test_spew_config_initialization.
  • Removed the unused test_basic_tracing.
  • Refactored 4 repetitive tests (for .pyc/.pyo files) into 2 cleaner, parameterized tests using @pytest.mark.parametrize.

This makes the test suite much cleaner and easier to maintain. This refactor removes 6 redundant tests and replaces 4 of them with 2 new parameterized tests, bringing the total test count from 80 to 78.

All 78 remaining tests pass.

Closes #13

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.55%. Comparing base (53ba658) to head (896abae).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files           4        4           
  Lines         203      203           
=======================================
  Hits          196      196           
  Misses          7        7           
Flag Coverage Δ
unittests 96.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Agent-Hellboy
Copy link
Owner

Hi @AyushAnand413 Thanks for the PR, per-commit hook is configured in the repo , you can install pre-commit in the repo after that it will automatically run from invocation of git commit, btw you should also run tox to verify things before pushing, please let me know if you need any help , you can search about these things on Internet.

@AyushAnand413
Copy link
Contributor Author

hey @Agent-Hellboy

I've applied the pre-commit fixes and corrected line endings as discussed. All checks should pass now. Please review when convenient, and let me know if anything else is needed before merging.

@AyushAnand413
Copy link
Contributor Author

@Agent-Hellboy please respond!!

@Agent-Hellboy
Copy link
Owner

Hi @AyushAnand413 i will check , I am busy with a regional festival.
If you have pending PRs for the hacktoberfest , I can merge this

@AyushAnand413
Copy link
Contributor Author

Yes please I have 1 pending out of 6 for hacktoberfest.

@Agent-Hellboy Agent-Hellboy merged commit 4b82db4 into Agent-Hellboy:main Oct 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manually remove redundent tests

2 participants