Refactor: Replace 6 redundant tests with 2 parameterized tests #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Agent-Hellboy ,
I've manually reviewed the test suite and removed redundancy as requested in issue #13.
Here are my changes:
test_spew_config_default_valuesintotest_spew_config_initialization.test_basic_tracing..pyc/.pyofiles) into 2 cleaner, parameterized tests using@pytest.mark.parametrize.This makes the test suite much cleaner and easier to maintain. This refactor removes 6 redundant tests and replaces 4 of them with 2 new parameterized tests, bringing the total test count from 80 to 78.
All 78 remaining tests pass.
Closes #13