Skip to content

Conversation

git-hulk
Copy link
Member

This PR only changes the internal behavior and won't affect the parsed output.

@git-hulk git-hulk requested a review from Copilot April 23, 2025 08:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the usage of expectTokenKind by removing its unused token return value to achieve consistency with expectKeyword, while keeping the parser’s behavior unchanged.

  • Replaces constructs returning token and error with error-only returns in expectTokenKind calls.
  • Updates all affected parser functions across multiple files to adapt to the new return signature.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
parser/parser_table.go Refactored expectTokenKind calls to remove unused token returns.
parser/parser_query.go Consistent changes to expectTokenKind calls across query parsing code.
parser/parser_common.go Updated expectTokenKind signature and related usages.
parser/parser_column.go Adjusted expectTokenKind usage in column and function expression parsers.
parser/parser_alter.go Modified expectTokenKind usage and token position assignment in projections.

@git-hulk git-hulk requested a review from Lance726 April 23, 2025 08:53
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14613988575

Details

  • 62 of 69 (89.86%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.785%

Changes Missing Coverage Covered Lines Changed/Added Lines %
parser/parser_common.go 11 12 91.67%
parser/parser_column.go 30 32 93.75%
parser/parser_query.go 4 8 50.0%
Totals Coverage Status
Change from base Build 14612920949: 0.0%
Covered Lines: 6934
Relevant Lines: 11044

💛 - Coveralls

@git-hulk git-hulk merged commit 9da9f1b into AfterShip:master Apr 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants