Open
Conversation
implementation ckpt 1 better type checking plus some bug fixes more impl
3f8ecd5 to
2949d59
Compare
Rostifar
commented
Oct 12, 2023
| mode=self.mode, | ||
| timestamp_field=self.timestamp_field, | ||
| source=self.source, | ||
| source=self.stream_source, |
Collaborator
Author
There was a problem hiding this comment.
This is a bug in __copy__. self.source isn't defined for SFV objects; instead, stream_source serves the same role as source.
Rostifar
commented
Oct 12, 2023
| source=self.stream_source, | ||
| udf=self.udf, | ||
| ) | ||
| fv.entities = self.entities |
Collaborator
Author
There was a problem hiding this comment.
A typing bug: type(self.entities) == List[str] while FeatureView's constructor requires Union[List[Entity], None].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specification: In-Memory Registry
Design
A
MemoryRegistryis a Docker image derived mapping fromFeastResourceidentifiers to in-memory Python objects, making it stateless between pods and deploys. AFeastResourceis a union of resource types:Some general constraints:
MemoryRegistryshould subclassBaseRegistryand behave like any other Feast registry duringapplycalls,FeatureStoreinstance is constructed,MemoryRegistryshould be populated by a thread-localfeast applycall,apply_*andget_*calls toMemoryRegistryshould use / return shallow-copied objects to reduce the risk of side effects,MemoryRegistryinstances should be immutable once theis_builtflag is set,protocalls toMemoryRegistryshould be evaluated on-demand to prevent space overhead,MemoryRegistryinstance should not exceed10MBof space usage (as determined bylen(dill.dumps(registry_instance)). At the moment (2023/10/10), the registry requires 0.3MB of RAM. MMAPing portions of the registry may be needed as things scale.